Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider publishing this package #1

Open
kirill-konshin opened this issue Oct 27, 2020 · 0 comments
Open

Consider publishing this package #1

kirill-konshin opened this issue Oct 27, 2020 · 0 comments

Comments

@kirill-konshin
Copy link

Looks like the code in https://github.com/Shelex/cypress-allure-snapshots-example/blob/master/cypress/support/index.js can be used in other projects by simply requiring it there.

Even though it's possible to set something like dependencies: {"cypress-allure-snapshots-example": "github://Shelex/cypress-allure-snapshots-example"} in package.json, there are few issue with that:

  1. The file needs to be pre-processed or import statements should be replaced by require
  2. Relative paths need to become configurable
  3. state.error && state.error.message === "Snapshot images do not match." should probably become optional if users decide to always include screenshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant