Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Cannot Asset to an Unavailable Kit (Although the Kit is available) #1069

Closed
carlosvirreira opened this issue Jun 18, 2024 · 1 comment · Fixed by #1076
Closed

[Bug]: Cannot Asset to an Unavailable Kit (Although the Kit is available) #1069

carlosvirreira opened this issue Jun 18, 2024 · 1 comment · Fixed by #1076
Assignees
Labels
bug Something isn't working

Comments

@carlosvirreira
Copy link
Contributor

Contact Details

No response

What happened?

Screen.Recording.2024-06-18.at.12.27.08.mov

Fair warning: These kits were added to a Booking which is on Reserved State. Not on Checked out state.

What is the expected behaviour?

Version

Hosted (app.shelf.nu)

What browsers are you seeing the problem on?

Safari

Relevant log output

No response

@carlosvirreira carlosvirreira added the bug Something isn't working label Jun 18, 2024
@DonKoko
Copy link
Contributor

DonKoko commented Jun 19, 2024

@carlosvirreira a fix for this is being deployed: https://github.com/Shelf-nu/shelf.nu/actions/runs/9582473645

I made sure that you can still add assets if the status is reserved. I also implemented a check also on the front-end so the manage assets button is disabled if any related bookings are ongoing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants