-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Foldable sidebar #54
Comments
Hi @DonKoko I was thinking about taking a similar approach as Mailchimp Screen.Recording.2023-04-03.at.11.59.10.mov
By hovering over the sidebar -> sidebar expands absolute -> with top right icon the user would be able to keep the sidebar in an open state (when clicked sidebar pushes the main content to the right)
When hovered, the sidebar would always be in an open state As you can see in the screen recording Mailchimp is not using an animation. I would be happy to prototype one or we can skip (for MVP). The behaviour described above is a bit different than what I had in mind when doing the designs. Let me know if you're down with this or not. Then I'll update / expand the design where needed. |
Okey i see. I personally find this very annoying functionality with this thing popping in and out the whole time, It just feels not so smooth, but I am open for giving it a test. Thanks for clarifying. |
What are your views on this example of foldable sidebar @DonKoko ? Demo: https://www.cssscript.com/demo/smooth-collapsible-sidebar-navigation/ should we follow the same approach? |
@hunar1312 yes, i like that its just a bunch of css. We do have already existing tooling to implement this tho using tailwind. So tailwind has all the classes to manage the folding and twMerge can help you dynamically merge classes. Here is an example how you can dynamically merge tailwind classes based on a condition: https://github.com/Shelf-nu/shelf.nu/blob/dev/app/components/shared/button.tsx#L46-L48 |
Yes will implement that with tailwind only. |
Yes please check the comment/video from @jurrejansen above. He explained how it should behave. |
We need to implement the functionality to make the sidebar foldable.
Design
Open state:
![image](https://user-images.githubusercontent.com/7840007/229462815-a673a8c7-d1e7-4e7b-a114-42394ee6640f.png)
Closed state:
![image](https://user-images.githubusercontent.com/7840007/229462872-3621774c-8e40-402f-b6b8-e5100c78d62c.png)
@jurrejansen @carlosvirreira
We are missing some designs related to this, or at least I cannot find them
Functionality
The text was updated successfully, but these errors were encountered: