Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement request]: Change date picker on custom field #894

Closed
carlosvirreira opened this issue Apr 3, 2024 · 10 comments
Closed

[Enhancement request]: Change date picker on custom field #894

carlosvirreira opened this issue Apr 3, 2024 · 10 comments
Assignees

Comments

@carlosvirreira
Copy link
Contributor

Contact Details

No response

Is your feature request related to a problem? Please describe?

I sometimes spend too much time clicking around with the current date modal for custom fields (date) to select the purchase date of my assets.

Some of my assets are 10 years old. Lots of clicking around.

Describe the solution you'd like

Can we use a date picker similar to the one we have in Bookings? Without the time field. Just date. Or just let me input a date in text.

Describe alternatives you've considered

No response

Additional context

No response

@carlosvirreira carlosvirreira added User requested feature Priority: Low Issues that are with low priority labels Apr 3, 2024
@DonKoko DonKoko added Priority: Medium Issues that are with medium priority and removed Priority: Low Issues that are with low priority labels Jun 7, 2024
@DonKoko
Copy link
Contributor

DonKoko commented Jun 7, 2024

@Bhavyajain21 I would like you to work on this when you are done with your current issue. Lets discuss it.

@Bhavyajain21
Copy link
Contributor

Sure @DonKoko

@Bhavyajain21
Copy link
Contributor

Bhavyajain21 commented Jun 8, 2024

Let's implement the similar Date field - as what we currently have under the Bookings? @DonKoko

@DonKoko
Copy link
Contributor

DonKoko commented Jun 10, 2024

@Bhavyajain21 yes, it needs to be just a normal html date input, the same as with bookings but without the time. That means we dont need the popover or anything like this as that comes native in the browser.

/bounty 10

Copy link

algora-pbc bot commented Jun 10, 2024

## 💎 $10 bounty • Shelf

### Steps to solve:
1. Start working: Comment /attempt #894 with your implementation plan
2. Submit work: Create a pull request including /claim #894 in the PR body to claim the bounty
3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to Shelf-nu/shelf.nu!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🟢 @Bhavyajain21 Jun 10, 2024, 7:39:32 AM #1046

@Bhavyajain21
Copy link
Contributor

Bhavyajain21 commented Jun 10, 2024

/attempt

Algora profile Completed bounties Tech Active attempts Options
@Bhavyajain21    5 Shelf-nu bounties
+ 7 bounties from 2 projects
TypeScript, Rust,
JavaScript & more
Cancel attempt

Copy link

algora-pbc bot commented Jun 10, 2024

💡 @Bhavyajain21 submitted a pull request that claims the bounty. You can visit your bounty board to reward.

Copy link

algora-pbc bot commented Jun 11, 2024

🎉🎈 @Bhavyajain21 has been awarded $10! 🎈🎊

@DonKoko
Copy link
Contributor

DonKoko commented Jun 11, 2024

@carlosvirreira this has been adjusted and released to live. We replaced the date picker with had with a native browser date picker which works smoother on all devices. We also included the button to clear it for the case when its a not required field and the user might want to do that. Would be great if you can inform the users that asked for it.

@DonKoko DonKoko closed this as completed Jun 11, 2024
@carlosvirreira
Copy link
Contributor Author

Doing right now and will be part of the small improvement notes on an upcoming Newsletter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants