Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]: Show who created a booking on the booking page #969

Open
carlosvirreira opened this issue May 10, 2024 · 6 comments
Open

Comments

@carlosvirreira
Copy link
Contributor

Contact Details

No response

Is your feature request related to a problem? Please describe?

I am on a mobile phone. I open a booking and I see an issue.

On desktop, when I go to the booking page. I have a column that shows me who created a booking. That way I can get in touch with this person to discuss things around the booking.

I have no way to do this on mobile.

Describe the solution you'd like

Add the booking creator data on the booking page on mobile and desktop.

Describe alternatives you've considered

No response

Additional context

No response

@DonKoko
Copy link
Contributor

DonKoko commented Jul 2, 2024

@jurrejansen can u make a quick design for this? I want to make a bounty. Lets keep it super simple.

@carlosvirreira
Copy link
Contributor Author

I think the issue here is that, although it looks nice on mobile the information on the booking tab. Is not giving much value.

I can see 'name' 'status' so it is not really giving me insight on the booking so I can take a quick action.

Things I should be able to answer by going to the booking tab on mobile for 1 asset:

  • Can I use this booking on (next week?)
  • If it is reserved, who reserved it?
  • Can I use this asset for a booking after it's done with the current booking? If so, when does it end?

@DonKoko
Copy link
Contributor

DonKoko commented Jul 2, 2024

OKey based on the issue title i was thinking about something completely different. You are talking about the asset page but based on the original issue i thought you were talking about the booking page. I think this is relevant in both cases. Lets decide which case this issue is for and create a different issue for the other case. Then we can tackle them both at some point.

@jurrejansen
Copy link

@DonKoko @carlosvirreira Perhaps we should then consider to not use the simplified tables on mobile and implement the horizontal scroll globally for tables. It works better than I expected anyways when I see tables like Custom fields for example. Would be best that only the content and column header are scrollable though.

Perhaps start with the Booking index?

Screenshot 2024-07-02 at 13 48 35

Screen.Recording.2024-07-02.at.13.42.13.mov

@carlosvirreira
Copy link
Contributor Author

If we do sidescroll, we have to find a way to make it super clear you can scroll to reveal more. At the moment not sure what/how.

@jurrejansen
Copy link

jurrejansen commented Jul 2, 2024

I think in most cases it is going to be pretty clear when the cells of a second column in a table are partly off screen. However the underlined approaches I kinda like but they're probably not 'keeping it simple'.

Screenshot 2024-07-02 at 14 35 12

Screenshot 2024-07-02 at 14 45 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants