fix(ssh): allow multiplexed connection #3658
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A Multiplexing connection can send more than one channel request over the same socket, making possible reuse the authentication method used by the master in the derivate ones. To support it, we should only allow the GliderSSH's server to dial with the connection on the agent's side, removing our intervention on the protocol flow, that enforces the channel limitation, just sending the device's response to the client. Closes #3656
henrybarreto
force-pushed
the
fix/ssh_multiplexing
branch
from
99d9782
to
85af17f
Compare
heiytor
approved these changes
Mar 28, 2024
|
Delayed for another moment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Multiplexing connection can send more than one channel request over the same socket, making possible reuse the authentication method used by the master in the derivate ones.
To support it, we should only allow the GliderSSH's server to dial with the connection on the agent's side, removing our intervention on the protocol flow, that enforces the channel limitation, just sending the device's response to the client.
Closes #3656