-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v2.0.3] Doesn't seem to pick up the babel presets. #78
Comments
@aga5tya thanks for the report. please fill in the issue template next time though, we ask that of everyone. the issue template has a section for |
@JounQin side note: this is probably and indicator that we should precompile in webpack-hot-client. I really didn't want to go that route (dynamic babel compilation was supposed to eliminate more issues rather than cause them), but it looks like it's needed in this context. |
Is there a runnable reproduction? Actually it runs very well in my own react project https://github.com/JounQin/react-hackernews . |
@JounQin @shellscape Mine is loosely based on React-Universally koa boilerplate, Will try to repro with bare one and share the repo asap. |
I'm unable to reproduce this with a bare version of react-universally. I'l dig deeper with the codebase I have and figure out where or what exactly I'm missing out on. Closing this until then. |
@aga5tya you can try installing |
I bumped to latest koa-webpack version, did the necessary changes suggested in the update notes. But can't seem to succeed with the compilation step. Doesn't seem to pick up the babel config for react(jsx). Not sure what am i missing here, But I end up with the below error.
Is there a config change I'm missing out with changes around babel transpilation ? Will be happy to provide more information if needed. @shellscape
[Edit]
Works fine on the previous version. So I might be missing something here.
The text was updated successfully, but these errors were encountered: