Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation of NormalModuleLoader hook #202

Closed
Aghassi opened this issue Oct 30, 2019 · 2 comments
Closed

Deprecation of NormalModuleLoader hook #202

Aghassi opened this issue Oct 30, 2019 · 2 comments

Comments

@Aghassi
Copy link

Aghassi commented Oct 30, 2019

https://github.com/danethurber/webpack-manifest-plugin/blob/4e02e21a61f2a7e41d36b0564d45c5f4932b0615/lib/plugin.js#L246

Webpack 5 throws a deprecation on this line, and I believe the remediation is to use NormalModule.getCompilationHooks as per the message I'm getting:

(node:17698) DeprecationWarning: Compilation.hooks.normalModuleLoader was moved to NormalModule.getCompilationHooks(compilation).loader
@Aghassi Aghassi mentioned this issue Oct 30, 2019
5 tasks
@mastilver
Copy link
Contributor

yes, we should try to reduce as much DeprecationWarning as possible, but we need to make sure the code is still compatible with v4

@shellscape
Copy link
Owner

Hey folks, please see #222 for updates on v5 support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants