Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider not using 'let' #22

Closed
jbardnz opened this issue Jun 2, 2016 · 1 comment
Closed

Consider not using 'let' #22

jbardnz opened this issue Jun 2, 2016 · 1 comment
Labels

Comments

@jbardnz
Copy link

jbardnz commented Jun 2, 2016

I was having issues running my code in FireFox and traced the issue back to the use of 'let' in this plugin. My FF was a couple of versions out of date and I noticed support for let is still not great, it was only supported in Chrome/FF as of a couple of versions ago and Safari/IE 10 has no support for it.

http://caniuse.com/#feat=let

Would you consider not using let so this plugin can support older browsers?

@shentao
Copy link
Owner

shentao commented Jun 2, 2016

Hey @jbardnz!
This should not happen since version v0.2 (released last night), as the plugin is now loaded as a babel transpiled umd bundle, which means all let uses are transpiled to var.

This means vue-multiselect should support browsers down to IE 9. :)

I added the /lib directory to the repository as this is where the package.json main key points to. You can preview the library file vue-multiselect.js there.

Please update to the newest version and let me know if this fixes the problem.

Additionally, keep in mind, that v0.2 introduces a minor breaking change in importing.
Instead of:

import Multiselect from 'vue-multiselect'`

you have to use object destructuring

import { Multiselect } from 'vue-multiselect'`

It is worth noting that you can now also import just the mixins and construct your own select components based on them. You can do this like this:

import { multiselectMixin, pointerMixin } from 'vue-multiselect'`

@shentao shentao added the invalid label Jun 2, 2016
@shentao shentao closed this as completed Jun 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants