Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration official #4

Open
pvizeli opened this issue Mar 1, 2021 · 6 comments
Open

integration official #4

pvizeli opened this issue Mar 1, 2021 · 6 comments
Assignees

Comments

@pvizeli
Copy link

pvizeli commented Mar 1, 2021

I think the time is good for replacing the old Dyson on the core. If you open a PR soon, it should go into 2021.4

@kintaroju
Copy link

i second that idea, especially with the 2FA in place, @shenxn dyson integration is the only one that works at the moment without issues, and works even better than the native version in place.

@shenxn
Copy link
Owner

shenxn commented Mar 9, 2021

I'll start working on that soon.

@shenxn shenxn self-assigned this Apr 29, 2021
@Kernald
Copy link

Kernald commented Jul 21, 2021

Any update on this? The current official integration has been broken for over six months now. I'm not trying to pressure you, but just wondering if removing the current integration in the meantime would be beneficial. There's no point in keeping something broken for that long, especially when it's advertised as working in the documentation (thinking of new users here, or people looking to buy such a device and deciding on this brand because of the Home Assistant integration).

@Jc2k
Copy link

Jc2k commented Aug 23, 2021

NM, just saw home-assistant/core#53801 👍 But if you do need any help let me know.

@Kakise Kakise assigned Kakise and unassigned shenxn Dec 16, 2021
@Kakise
Copy link
Collaborator

Kakise commented Dec 16, 2021

@Flameeyes would you like to help me out and merge this integration with me ?

@Flameeyes
Copy link
Contributor

@Flameeyes would you like to help me out and merge this integration with me ?

Sure, it definitely would make it easier to handle version compatibility :)

I think before that we might want to use the enum version of device_class and company, I was planning on sending a pull request tomorrow/this weekend for it.

@Kakise Kakise added this to To do in v0.17 Roadmap Dec 18, 2021
@Kakise Kakise moved this from To do to In progress in v0.17 Roadmap Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
v0.17 Roadmap
In progress
Development

No branches or pull requests

7 participants