Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time augment for Google Stock forecasting experiment #8

Open
mhkim9714 opened this issue Nov 3, 2023 · 0 comments
Open

Time augment for Google Stock forecasting experiment #8

mhkim9714 opened this issue Nov 3, 2023 · 0 comments

Comments

@mhkim9714
Copy link

Hi, first of all thanks for introducing this fabulous work!
I have a question regarding the _process_data inside the stock.py.
As shown in https://github.com/patrick-kidger/NeuralCDE/blob/master/example/example.py, shouldn't we augment time before the features of the data?
The final data before computing the coefficients for the natural cubic spline interpolation is shaped
X : [3661,24,6]
y : [3661,1,6] (when assuming single-step forecast of lag 24 and horizon 1)
The last dimension '6' means {Open, High, Low, Close, Adj_Close, Volume} of the stock_data.csv.
I think the last dimension should be 7 including {time, Open, High, Low, Close, Adj_Close, Volume}.
If I am misunderstanding something about the NCDE implementation, please feel free to correct me.
Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant