Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES6 in dist #1529

Closed
Eduardo-Julio opened this issue Jul 1, 2021 · 6 comments
Closed

ES6 in dist #1529

Eduardo-Julio opened this issue Jul 1, 2021 · 6 comments
Labels

Comments

@Eduardo-Julio
Copy link

Eduardo-Julio commented Jul 1, 2021

As previously seen in this issue #626

The dist has ES6 which makes problems with a lot of stuff which are expecting ES5 in dists.

@RobbieTheWagner
Copy link
Member

@Eduardo-Julio can you please be more specific? What Shepherd version and what are you seeing?

@Eduardo-Julio
Copy link
Author

nted on Sep 16, 2021

Sorry for the delay.

shepherd.js@8.3.1

shepherd.js\dist\js\shepherd.min.js

Copy the code and test it here https://eslint.org/demo
In "Rules Configuration" select ECMA Version 5, you can see that it fails to compile because it has ES6 features.

@Eduardo-Julio
Copy link
Author

Other issues related to this one

#626
#210

@RobbieTheWagner
Copy link
Member

@Eduardo-Julio we do not support internet explorer, and all other browsers have supported ES6 for many years.

@Eduardo-Julio
Copy link
Author

We also don't support internet explorer, and your response doesn't address the issue I think.

This affects our build process in a part where we expect ES5 to finish the build, we use a lot of packages and this is the first one that gives a dist with ES6 and not ES5, that's why I created the issue.

But if you don't want to change it that's fine.

@RobbieTheWagner
Copy link
Member

@Eduardo-Julio can you please help me understand the issue? If you are not supporting internet explorer, what's wrong with ES6 in the dist?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants