Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate selectors for modal overlay cutout target and popper target #1836

Open
wbobeirne opened this issue Mar 3, 2022 · 2 comments · May be fixed by #1837
Open

Separate selectors for modal overlay cutout target and popper target #1836

wbobeirne opened this issue Mar 3, 2022 · 2 comments · May be fixed by #1837

Comments

@wbobeirne
Copy link

I'm using the modal overlay in my Shepherd tour, but I'd like to point the tooltip at a specific element that's inside the cutout area. Here's an example, I'd like the tooltip to point directly at the orange button. I tried using left-start to move it to the top, but unfortunately no amount of configuration will get the arrow to point directly at the button:

Screen Shot 2022-03-03 at 3 06 59 PM

It'd be great if attachTo had an optional second element attribute for either popper target, or the overlay cutout target, so that they can be two separate elements. By default they should both be the same. Not sure if you'd rather an option for each, or go with just one or the other.

@wbobeirne wbobeirne changed the title Separate selectors for modal cutout target and popper target Separate selectors for modal overlay cutout target and popper target Mar 3, 2022
@RobbieTheWagner
Copy link
Member

@wbobeirne I would certainly be open to this. Would you like to give implementing it a try?

@wbobeirne
Copy link
Author

wbobeirne commented Mar 4, 2022

Sounds good, given that the modal overlay is optional I think that it's the one that should get a separate selector option. Would you prefer it to be nested under attachTo, or its own top-level config?

@wbobeirne wbobeirne linked a pull request Mar 5, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants