Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial document type declaration handling #37

Merged
merged 2 commits into from
Dec 23, 2016
Merged

Add initial document type declaration handling #37

merged 2 commits into from
Dec 23, 2016

Conversation

ljedrz
Copy link
Contributor

@ljedrz ljedrz commented Dec 23, 2016

For now it only supports the SYSTEM variant without the optional intSubset. I only started working with this code today, I'm open to any criticism and modifications.

@shepmaster shepmaster merged commit 3a930a9 into shepmaster:master Dec 23, 2016
@shepmaster
Copy link
Owner

Thanks!

@shepmaster
Copy link
Owner

I'm assuming you ran into this with a real-world usecase, does this PR by itself help solve whatever problem you are facing, or do you think there are more coming? Asked another way: would you like to see this released?

@ljedrz
Copy link
Contributor Author

ljedrz commented Dec 23, 2016

Yes, I encountered this with documents that had a DTD specified - they caused panics without it. I think this implementation covers the most popular case (when you just want to ignore the DTD and parse the actual content) and could be helpful on its own, but I might hit some other unimplemented cases after Christmas if you would like to pull some more code before doing a release.

@ljedrz ljedrz deleted the DocumentTypeDeclaration branch December 27, 2016 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants