Implement std::error::Error for parser::Error.
#42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shepmaster
requested changes
Apr 17, 2017
src/parser.rs
Outdated
| ExpectedElementName => "expected element name", | ||
| ExpectedElementEnd => "expected element end", | ||
| ExpectedElementSelfClosed => "expected element self closed", | ||
| ExpectedProcessingInstruction => "expected prcosessing instruction", |
|
Thanks so much! I'm a big fan of quick-error myself! |
|
I fixed the typo on line 144 in the updated commit. (If I should send them as separate commits in the future, please let me know. I just thought this way there would be less commit log spam.) |
shepmaster
approved these changes
Apr 17, 2017
|
Published 0.2.1 with these changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would allow for better interoperability with other error handling crates, particularly with
the
error-chaincrate.If you are unhappy with something feel free to tell me, especially if I should change something about the strings.