Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore default namespace for attribute prefixes #45

Merged
merged 1 commit into from
May 30, 2017
Merged

Ignore default namespace for attribute prefixes #45

merged 1 commit into from
May 30, 2017

Conversation

draivin
Copy link
Contributor

@draivin draivin commented May 29, 2017

Attribute prefixes should ignore the current default namespace, see
https://stackoverflow.com/questions/3312390/xml-default-namespaces-for-unqualified-attribute-names

I've made a quick implementation by adding a bool to the related methods and setting it to true when dealing with attributes, but I feel this is somewhat dirty, if you have any preferences please let me know.

@shepmaster
Copy link
Owner

but I feel this is somewhat dirty

Yeah, boolean arguments always give me that feeling too! However, I think it's the right thing to do to get the fix and test in. Can always see if a better solution raises its head later.

@shepmaster shepmaster merged commit 9a0dc13 into shepmaster:master May 30, 2017
@shepmaster shepmaster added the bug label May 30, 2017
@shepmaster
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants