Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in utf8valid #20

Closed
akmalxxx opened this issue Jul 10, 2016 · 5 comments
Closed

Bug in utf8valid #20

akmalxxx opened this issue Jul 10, 2016 · 5 comments

Comments

@akmalxxx
Copy link

utf8valid will fail on utf8 file with 2 or more linebreaks in a row.

@sheredom
Copy link
Owner

Oh nice find! Can I just confirm its "\n\n" that is causing your failure?

@akmalxxx
Copy link
Author

Yes it was a sequence of \n\n...

@sheredom
Copy link
Owner

Any chance you could give me the input you were failing on? I've just tried

UTEST(utf8valid, linebreaks) {
  ASSERT_EQ(0, utf8valid("\n\n\n\n\n\n\n\n\n\n\n"));
}

And it works as intended.

@akmalxxx
Copy link
Author

I'm sorry there was a small mistake in my string construction, utf8valid works just fine. Thank you for a nice clean library :)

@sheredom
Copy link
Owner

@fatfingers no bother! Glad the lib is useful to you 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants