This repository has been archived by the owner on May 26, 2023. It is now read-only.
GalloDaSballo - M-01 executeSwap
doesn't work
#46
Labels
executeSwap
doesn't work
#46
GalloDaSballo
medium
M-01
executeSwap
doesn't workSummary
Due to most likely a programming mistake,
executeSwap
will callexecuteSwapDirect
and then revert.Vulnerability Detail
Impact
Because
executeSwap
callsexecuteSwapDirect
it will always revert.HardenedTopUpProxy is not programmed to call it either, leading me to believe this is a programming mistake.
Code Snippet
https://github.com/sherlock-audit/2022-10-mover/blob/main/cardtopup_contract/contracts/ExchangeProxy.sol#L91-L92
function executeSwap(
Tool used
Manual Review
Recommendation
Delete the code if unused.
Or refactor to allow any caller to use it.
The text was updated successfully, but these errors were encountered: