This repository has been archived by the owner on May 26, 2023. It is now read-only.
cmichel - Spec: Wrong description of withdrawal process #94
Labels
Has Duplicates
A valid issue with 1+ other issues describing the same vulnerability
Reward
A payout will be made for this issue
Specification
An issue related to the specification (low severity)
cmichel
low
Spec: Wrong description of withdrawal process
Summary
Wrong description of the withdrawal process in the spec.
Vulnerability Detail
The
withdrawals.md
describes the second step of the withdrawal process as:The
getL2OutputAfter
call is never performed. This function does not even exist, most likely, it was referring togetL2OutputIndexAfter
. However, even this function is not called. What happens in the withdrawal process is thatgetL2Output
is called to retrieve the output root for the given block number (index).Impact
The withdrawal process should be clearly documented in the spec. Currently, it's referring to a non-existant function.
Code Snippet
https://github.com/ethereum-optimism/optimism/blob/3f4b3c328153a8aa03611158b6984d624b17c1d9/specs/withdrawals.md?plain=1#L67
Tool used
Manual Review
Recommendation
Fix the spec by referring to
getL2Output(l2OutputIndex)
instead.The text was updated successfully, but these errors were encountered: