rvierdiiev - LMPVaultRouterBase.mint tries to get payment 2 times in case of native payment

[sherlock-admin2]

rvierdiiev

medium

LMPVaultRouterBase.mint tries to get payment 2 times in case of native payment

Summary

LMPVaultRouterBase.mint tries to get payment 2 times in case of native payment

Vulnerability Detail

LMPVaultRouterBase.mint is payable and user can provide value with the call.

In this case, payment will be deposited to the weth.

But later, contract will try to get funds again and this will fail in case if user doesn't have allowance, or in case if it has, then he will loose funds.

Impact

Function will not work as expected

Code Snippet

Provided above

Tool used

Manual Review

Recommendation

In case of native payment do not pull funds again.

Duplicate of #1