AuditorPraise - LMPVaultRegistry.removeVault doesn’t remove vault from _vaultsByType mapping

[sherlock-admin]

AuditorPraise

medium

LMPVaultRegistry.removeVault doesn’t remove vault from _vaultsByType mapping

Summary

LMPVaultRegistry.removeVault doesn’t remove vault from _vaultsByType mapping

Vulnerability Detail

when vaults are added via LMPVaultRegistry.addVault(), the vaults are added to 3 mappings

1. _vaults mapping, see here
2. _vaultsByAsset mapping, see here
3. _vaultsByType mapping, see here

But when the vaults are being removed via LMPVaultRegistry.removeVault(), LMPVaultRegistry.removeVault() fails to remove the vault from _vaultsByType mapping.

• it removes the vault from _vaults mapping here and _vaultsByAsset mapping here

But it fails to remove the vault from _vaultsByType mapping.

Therefore a removed vault will still exist in _vaultsByType mapping

Impact

• A removed vault will still exist in _vaultsByType mapping
• And if there be any need to re-add the vault via LMPVaultRegistry.addVault() there will be a revert because of this line
• function listVaultsForType() will still list the removed vault as one of the available vaults for a particular type, see here

Code Snippet

https://github.com/sherlock-audit/2023-06-tokemak/blob/main/v2-core-audit-2023-07-14/src/vault/LMPVaultRegistry.sol#L64

Tool used

LOFI Radio and Manual Review

Recommendation

remove the vault from _vaultsByType mapping too in the LMPVaultRegistry.removeVault() function

Duplicate of #674