Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

0x52 - Issue #145 from Update #1 is still present in IchiSpell #107

Closed
sherlock-admin2 opened this issue Aug 15, 2023 · 0 comments
Closed

0x52 - Issue #145 from Update #1 is still present in IchiSpell #107

sherlock-admin2 opened this issue Aug 15, 2023 · 0 comments
Labels
Non-Reward This issue will not receive a payout

Comments

@sherlock-admin2
Copy link
Contributor

sherlock-admin2 commented Aug 15, 2023 •
edited
Loading

0x52

high

Issue #145 from Update #1 is still present in IchiSpell

Summary

Issue 145 from Update 1 has not been fixed. Using block.timestamp is equivalent to using no deadline at all. This is because block.timestamp is relative and always "now", which means it can never be in the past and can therefore never be expired.

Vulnerability Detail

See Issue 145

Impact

See Issue 145

Code Snippet

IchiSpell.sol#L199-L256

Tool used

Manual Review

Recommendation

Use a user specified input as the deadline

Duplicate of #14
@github-actions github-actions bot added Medium A valid Medium severity issue Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label labels Aug 17, 2023
@sherlock-admin2 sherlock-admin2 changed the title Magnificent Mercurial Swift - Issue #145 from Update #1 is still present in IchiSpell 0x52 - Issue #145 from Update #1 is still present in IchiSpell Aug 25, 2023
@sherlock-admin2 sherlock-admin2 added Non-Reward This issue will not receive a payout and removed Medium A valid Medium severity issue Duplicate A valid issue that is a duplicate of an issue with `Has Duplicates` label labels Aug 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Non-Reward This issue will not receive a payout
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sherlock-admin2