unix515 - Invalid condition - mint will be not worked although native token is sufficient.

[sherlock-admin2]

unix515

medium

Invalid condition - mint will be not worked although native token is sufficient.

Summary

Invalid condition - mint will be not worked although native token is sufficient.

Vulnerability Detail

If the msg.value is not strictly equal "quantity * PRICE", "premint" and "mint" will be not worked although the native token is sufficiently provided.

Impact

"premint" and "mint" will not be worked although msg.value is sufficiently provided..

Code Snippet

https://github.com/sherlock-audit/2023-10-looksrare/blob/main/contracts-infiltration/contracts/Infiltration.sol#L450
https://github.com/sherlock-audit/2023-10-looksrare/blob/main/contracts-infiltration/contracts/Infiltration.sol#L482

Tool used

Manual Review

Recommendation

Please correct the condition.

function premint(address to, uint256 quantity) external payable onlyOwner {
--	if (quantity * PRICE != msg.value) {
++	if (quantity * PRICE > msg.value) {
		revert InsufficientNativeTokensSupplied();
	}
	...
}

function mint(uint256 quantity) external payable nonReentrant {
	...
	uint256 amountMinted = amountMintedPerAddress[msg.sender] + quantity;
	if (amountMinted > MAX_MINT_PER_ADDRESS) {
		revert TooManyMinted();
	}

--	if (quantity * PRICE != msg.value) {
++	if (quantity * PRICE > msg.value) {
		revert InsufficientNativeTokensSupplied();
	}

	if (totalSupply() + quantity > MAX_SUPPLY) {
		revert ExceededTotalSupply();
	}

	...
}

[nevillehuang]

No issue here, design choice that has the benefit of preventing users from paying excessive amounts and to avoid a explicit refund mechanism.