Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

santiellena - USDbC (Bridged USDC on Base) may cause insolvency in the protocol if it deppegs from USDC #203

Closed
sherlock-admin2 opened this issue Feb 16, 2024 · 2 comments
Labels
Excluded Excluded by the judge without consulting the protocol or the senior Non-Reward This issue will not receive a payout Sponsor Disputed The sponsor disputed this issue's validity Won't Fix The sponsor confirmed this issue will not be fixed

Comments

@sherlock-admin2
Copy link

sherlock-admin2 commented Feb 16, 2024

santiellena

medium

USDbC (Bridged USDC on Base) may cause insolvency in the protocol if it deppegs from USDC

Summary

Failure to use a correct oracle address can cause unexpected pricing behavior in the USDbC pool.

Vulnerability Detail

The lack of a Chainlink Price Feed for USDbC and the decision to use the USDC Price Feed for the token, in the case of a depeg of the bridged token from USDC, users will be able to arbitrage with other protocols taking debt at a non-real price.

Impact

This potential depeg, as the protocol won't be able to handle it, may cause a drain of the tokens from the pool.

Code Snippet

As written in accounts-v2/test/fork/asset-modules/stargate/USDbCPool.fork.t.sol line 38-40:
https://github.com/sherlock-audit/2023-12-arcadia/blob/main/accounts-v2/test/fork/asset-modules/stargate/USDbCPool.fork.t.sol#L38-L40

It is clear that the intentions are to use USDC oracle for USDbC.

Similar issues:

Tool used

Manual Review

Recommendation

Avoid using tokens that don't have an available oracle.

@github-actions github-actions bot added the Excluded Excluded by the judge without consulting the protocol or the senior label Feb 21, 2024
@sherlock-admin2
Copy link
Author

1 comment(s) were left on this issue during the judging contest.

takarez commented:

invalid

@nevillehuang
Copy link
Collaborator

Invalid, agree with sponsors comments:

  • There is no (and there will not be) a separate oracle for USDbC on Base (this was confirmed with Chainlink, Circle and Base). Circle wants to phase out USDbC
  • Has to be taken into account in appropriate risk factors (maxExposure + risk factors)

@sherlock-admin2 sherlock-admin2 added Sponsor Disputed The sponsor disputed this issue's validity Won't Fix The sponsor confirmed this issue will not be fixed labels Feb 27, 2024
@sherlock-admin sherlock-admin changed the title Glamorous Daffodil Mole - USDbC (Bridged USDC on Base) may cause insolvency in the protocol if it deppegs from USDC santiellena - USDbC (Bridged USDC on Base) may cause insolvency in the protocol if it deppegs from USDC Feb 28, 2024
@sherlock-admin sherlock-admin added the Non-Reward This issue will not receive a payout label Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Excluded Excluded by the judge without consulting the protocol or the senior Non-Reward This issue will not receive a payout Sponsor Disputed The sponsor disputed this issue's validity Won't Fix The sponsor confirmed this issue will not be fixed
Projects
None yet
Development

No branches or pull requests

3 participants