Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable SSL Certificate Verification #1388

Open
2 tasks done
spacemishka opened this issue Jun 29, 2022 · 12 comments
Open
2 tasks done

Disable SSL Certificate Verification #1388

spacemishka opened this issue Jun 29, 2022 · 12 comments
Labels
enhancement New feature or request

Comments

@spacemishka
Copy link

  • I'm reporting a feature request
  • I've checked for similar feature requests including closed ones

Could you implement a switch to disable the verification of SSL Certificates? It could be useful behind some proxies. Currently i am facing this issue

(Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:997)'))) Using the proxy:

thanks!

@spacemishka spacemishka added the enhancement New feature or request label Jun 29, 2022
@Sebhadde
Copy link

Hh

@spacemishka
Copy link
Author

Hh

sorry?

@0xdavidel
Copy link
Contributor

Hi spacemishka

What website gave you the error?
Are you able to recreate this error reliably?

@spacemishka
Copy link
Author

I get this with any website and i is always happen when running behind a proxy. NO issues when using Python requests with ssl verification disabled.

@0xdavidel
Copy link
Contributor

I think that the best course of action is to add an argument that disables SSL checks in requests
that argument should be accessible from where the request is being sent

and pass the boolean into an argument called verify. when verify = False requests wont check SSL integrity

I will work on that if I get a chance, but feel free to take over this.

@0xStryK3R
Copy link

Hi @DavidEl03 , I would like to take this up if this issue is still pending. Do assign it to me if it is open for contribution.

@0xdavidel
Copy link
Contributor

@0xStryK3R feel free to implement the changes, I think it's still up for grabs. Just double check if it's still an issue by using the tool with VPN or proxy

@Dragonblue96
Copy link

  • I'm reporting a feature request

    • I've checked for similar feature requests including closed ones

Could you implement a switch to disable the verification of SSL Certificates? It could be useful behind some proxies. Currently i am facing this issue

(Caused by SSLError(SSLCertVerificationError(1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:997)'))) Using the proxy:

thanks!

how did you fix this issue?
Please help me I'm facing the similar issue

@sdushantha
Copy link
Member

This is an issue with your environment and not Sherlock itself. I've encountered similar issues with cURL before and was able to fix it systemwide. Unsure what I did but did find it on Stackoverflow somewhere

@0xdavidel
Copy link
Contributor

This is an issue with your environment and not Sherlock itself. I've encountered similar issues with cURL before and was able to fix it systemwide. Unsure what I did but did find it on Stackoverflow somewhere

Hey bud, this is definitely a needed feature and a real issue, changing system wide configuration just for a single tool is not a viable solution. It's just an opening for trouble down the road for those users.

@sdushantha sdushantha reopened this Feb 5, 2023
@sdushantha
Copy link
Member

Yeah thats a good point, didn't think about that. I've opened this issue and if @0xStryK3R still wants to work on this, I'll take a look at the PR 👍

@ll299
Copy link

ll299 commented Mar 25, 2023

Hi, our team is working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants