Adding help labels

[daviddavo]

If you create a form and you want to add help labels, you'll have to do it manually. It'd be nice to be able to do it in sherlockode_configuration, perhaps alongside label or inside options.

If this is already possible, we could just add it to the README

[Vowow]

Hello,

This is not yet possible but could be an interesting feature.
One problem though is that we don't provide any style or JS in the bundle and we are not sure we want to provide one.
If I had to do it in a project, I'll do a form_theme inside my project, not sure if it should be packaged within this bundle.
What kind of feature have you got in mind ? Something like a tooltip ?
You can still provide us a Pull request for this one and we'll be happy to review it !

[daviddavo]

I tried just adding help to the $baseOptions and it just works. Symfony's default form themes work fine with it.

configuration-bundle/Form/Type/ParametersType.php

Lines 36 to 43 in e860def

	$baseOptions = [
	'label' => $definition->getLabel(),
	'required' => $definition->getOption('required', true),
	'attr' => $definition->getOption('attr', []),
	'row_attr' => $definition->getOption('row_attr', []),
	'label_attr' => $definition->getOption('label_attr', []),
	'translation_domain' => $definition->getTranslationDomain(),
	];

I will open a PR as soon as I can

[Vowow]

This could be done by using options directly in our bundle like this :

my_config_field:
    label: parameters.tarte_au_citron_id
    type: simple
    options:
        required: false
        help: 'toto'

Could be interesting to give in baseOptions all the options that are inherited in Symfony form components though.
I'll review the PR and maybe amend to give more options to the user, it's a good idea

[daviddavo]

Here's the list of options: https://symfony.com/doc/current/reference/forms/types/form.html#field-options

And here is the code of the FormType:

https://github.com/symfony/symfony/blob/6.3/src/Symfony/Component/Form/Extension/Core/Type/FormType.php

It seems to use an OptionsResolver to handle the options: https://github.com/symfony/symfony/blob/6.3/src/Symfony/Component/OptionsResolver/OptionsResolver.php

[juchi]

PR has been merged