Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building with Docker (and therefore GitHub actions #33

Open
shermp opened this issue Nov 14, 2020 · 5 comments · May be fixed by #47
Open

Building with Docker (and therefore GitHub actions #33

shermp opened this issue Nov 14, 2020 · 5 comments · May be fixed by #47

Comments

@shermp
Copy link
Owner

shermp commented Nov 14, 2020

So, I really want to get some github actions going, but I kind of need a docker image to do it with.

The easiest option looks to be golang-crossbuild. My main concern is that this won't have any Kobo specific tweaks to the build system. How critical are the Kobo tweaks @NiLuJe ?

Another option might be to extend the koreader/kokobo image with Go, if I can get it working.

Or I could build my own koxtoolchain + Go docker image.

Another option may be NickelTC, although I would prefer newer compiler versions for building Go programs.

Any thoughts @NiLuJe or @pgaskin ?

@NiLuJe
Copy link
Contributor

NiLuJe commented Nov 14, 2020

I have no idea what golang-crossbuild uses, but it appears to be Debian based, so, even despite that fact, it's going to be hilariously too recent, so, it'll just create plain unusable binaries ;).

You should be able to use koxtoolchain on pretty much anything, though, so, basically anything that works for you as a base can be tweaked to include a usable TC.

@shermp
Copy link
Owner Author

shermp commented Nov 15, 2020

I have no idea what golang-crossbuild uses, but it appears to be Debian based, so, even despite that fact, it's going to be hilariously too recent, so, it'll just create plain unusable binaries ;).

Thanks for the heads-up on that. It's a no-go then.

Ah, finally found the comment from @pgaskin with a starting point Dockerfile. I knew he had posted it somewhere...

Might polish it up, chuck it on Github, and push an image to Docker Hub, or the new Github container registry perhaps.

@pgaskin
Copy link
Contributor

pgaskin commented Nov 15, 2020

This is pretty simple to do no matter which approach you take, although adding Go to an existing image will probably be the shortest.

or the new Github container registry perhaps

The main issue with that one is it wants authentication to pull images.

@shermp
Copy link
Owner Author

shermp commented Nov 15, 2020

The main issue with that one is it wants authentication to pull images.

Really? From what I've read, that applies to GitHub packages. However, from what I've read, the container registry that was recently announced allows public images to be pulled anonymously.

@pgaskin
Copy link
Contributor

pgaskin commented Nov 15, 2020

Oh, that's new. I'll probably switch most references to NickelTC to it then.

@aricodes-oss aricodes-oss linked a pull request Aug 8, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants