Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink the tolerance for the optimization methods and the EstMethod class. #449

Open
dtnguyen2 opened this issue May 7, 2018 · 4 comments

Comments

@dtnguyen2
Copy link
Contributor

We need to re-think the default tolerance for the optimization methods and the EstMetho class. For lmdif, epsfcn should remain to be EPSILON (1.1920928955078125e-07) but ftol, xtol and gtol should not be EPSILON, etc... At the very least one may want to consider the tolerance within the EstMethod for the optimization method to be the same setting as eps for the EstMethod.

def lmdif(fcn, x0, xmin, xmax, ftol=EPSILON, xtol=EPSILON, gtol=EPSILON,
maxfev=None, epsfcn=EPSILON, factor=100.0, verbose=0):

def montecarlo(fcn, x0, xmin, xmax, ftol=EPSILON, maxfev=None, verbose=0,
seed=74815, population_size=None, xprob=0.9,
weighting_factor=0.8):

def neldermead( fcn, x0, xmin, xmax, ftol=EPSILON, maxfev=None,
initsimplex=0, finalsimplex=9, step=None, iquad=1,
verbose=0 ):

class EstMethod(NoNewAttributesAfterInit):

# defined pre-instantiation for pickling
config = {'sigma': 1,
          'eps': 0.01,
          'maxiters': 200,
          'soft_limits': False}
@anetasie
Copy link
Contributor

anetasie commented Apr 8, 2020

@dtnguyen2 what does eps in this class do?

@dtnguyen2
Copy link
Contributor Author

Sherpa's conf, with an appropriate coordinate transformation, is basically a 1-d root finding algorithm. So eps is the tolerance for finding said root.

@anetasie
Copy link
Contributor

anetasie commented Apr 8, 2020

Is this eps only used in conf?

@dtnguyen2
Copy link
Contributor Author

eps`` is used in confandproj```, which technically is yes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants