Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example for "value shape" uses unsupported JSON key #20

Closed
tombaker opened this issue Oct 25, 2020 · 4 comments
Closed

Example for "value shape" uses unsupported JSON key #20

tombaker opened this issue Oct 25, 2020 · 4 comments

Comments

@tombaker
Copy link
Contributor

In 3.1. Node Constraints, the example for "value shape" reads:

{ "my:IssueShape": { "type": "Shape",
  "expression": { "type": "TripleConstraint", "predicate": "ex:reportedBy",
      "value": { "type": "ShapeRef", "reference": "my:PersonShape" } } } }

However, there is no mention of the key "reference" in the ShExJ grammar.

@ericprud
Copy link

Before we updated ShExJ to be more JSON-LD-friendly, it used a ShapeRef structure to reference other shapes. The JSON-LD update replaced that with a JSON-LD @id, e.g. {"type":"ShapeRef","reference":"http://...Shape1"} became "http://...Shape1". 9d95471 fixes this. I pushed that to master and extends.

Please close if appropriate.

@tombaker
Copy link
Contributor Author

@ericprud This looks good but the ShapeRef structure still dispays on shex.io/shex-primer ...?

@ericprud
Copy link

ericprud commented Oct 30, 2020

I just patched http://shex.io/shex-primer-20191009 with 9d95471.

Look good?

@tombaker
Copy link
Contributor Author

tombaker commented Nov 4, 2020

Looks good - thanks.

@tombaker tombaker closed this as completed Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants