Removed menu #54
Removed menu #54
Conversation
menu is removed and an about link added
|
Looks good to me |
| {queryStringParm: "interface", location: $("#interface"), deflt: "human" }, | ||
| {queryStringParm: "regexpEngine", location: $("#regexpEngine"), deflt: "threaded-val-nerr" }, | ||
| ]); | ||
| var QueryParams = Getables.concat([]); |
There was a problem hiding this comment.
The .concat() is unnecessary now, this could also just be var QueryParams = Getables; as far as I can tell.
| @@ -229,33 +229,9 @@ | |||
| <!-- </ul> --> | |||
| <form id="menuForm"> | |||
| <button id="menu-button" title="click for menu"> | |||
There was a problem hiding this comment.
I don’t think the “click for menu” title is accurate anymore, but I’m not sure.
|
Did this also remove the result section? It seems it is now only possible to get a binary answer (True or False) but the necessary information to point to the actual location where the data does not fit the schema, Like here: https://colab.research.google.com/drive/1Y1Wv9TGVzEIe26vvXhQuxFUHXKqij-hk |
|
I agree that removing the results section makes it basically impossible to diagnose errors. |
|
I’m really confused now. Removing the results has nothing to do with this pull request, as far as I can tell, but was done in e0bca4c (#46). And I’m pretty sure we don’t that in the Wikidata case – I don’t even see the binary answer @andrawaag mentions, as far as I can tell there aren’t any results at all, which can’t be what we want. |
|
They're only connected by the idea that both can be controlled through the mechansim i used to switch the [control] button on/off. Re the advisability of turning off results, I agree. It's easy to re-enable them if that's what folks want. |
Yes, please do :) we’ll have to find another way to disable displaying the parsed schema without removing the results as well. |
|
after extensive editing, i was able to fulfill this request |
No description provided.