Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script doesn't exit #12

Closed
adrianchmura1 opened this issue Feb 26, 2019 · 2 comments
Closed

Script doesn't exit #12

adrianchmura1 opened this issue Feb 26, 2019 · 2 comments

Comments

@adrianchmura1
Copy link

Hey,

Nice tool! I succesfully set up some useful hooks using it ;)

I tried to set up pre commit hook to run swiftlint which I got installed globally:

"pre-commit": [ "swiftlint" ]

The problem is the hook doesn't exit when project has a lot of warnings. When I modify swiftlint to execute it against a single file (which has less number of warnings) it exits normally. Swiftlint is working correctly when running directly from terminal. It is likely caused by shellOut in runner.swift script

@nicholascross
Copy link

Would running “swiftlint —strict” help?

This should cause it to fail on warnings.

@adrianchmura1
Copy link
Author

Yeah it works that way.
But I'd prefer that script just prints out warnings instead of failing. I'm afraid hooks are going to freeze if any script produce huge number of logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants