Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing unversioned symbolic link for GNUABI version in 3.6 #532

Closed
musicinmybrain opened this issue Mar 18, 2024 · 3 comments · Fixed by #535
Closed

Missing unversioned symbolic link for GNUABI version in 3.6 #532

musicinmybrain opened this issue Mar 18, 2024 · 3 comments · Fixed by #535

Comments

@musicinmybrain
Copy link
Contributor

musicinmybrain commented Mar 18, 2024

In release 3.6, with -DSLEEF_BUILD_GNUABI_LIBS:BOOL=TRUE, CMake no longer produces the unversioned shared-library symlink libsleefgnuabi.so.

Only the library libsleefgnuabi.so.3.6 and the symbolic link libsleefgnuabi.so.3 are installed.

(See https://sleef.org/additional.xhtml#gnuabi for an example using -lsleefgnuabi: this requires libsleefgnuabi.so.)

Both libsleef.so and libsleefquad.so have the correct unversioned symbolic links.

@musicinmybrain
Copy link
Contributor Author

It looks like 29391cc might affect this, but I haven’t tested it yet.

@blapie
Copy link
Collaborator

blapie commented Mar 18, 2024

Thanks for the report. Will look into that as soon as I can.

It looks like 29391cc might affect this, but I haven’t tested it yet.

You are right, it very well could solve that. But not 100% sure, haven't checked more closely yet.

@musicinmybrain
Copy link
Contributor Author

It looks like 29391cc might affect this, but I haven’t tested it yet.

It affects it, but the wrong way: now libsleef.so is also missing the unversioned symlink!

Note that libsleef.so/libsleefgnuabi.so are in the CMake build directory, but they are not installed anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants