Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update getCategory so it can take a query too #67

Open
jameskirkby opened this issue May 7, 2019 · 0 comments
Open

Update getCategory so it can take a query too #67

jameskirkby opened this issue May 7, 2019 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@jameskirkby
Copy link
Contributor

In src/express/category-handler.js, update:

const response = await SHIFTClient.getCategoryV1(req.params.id)

To

const response = await SHIFTClient.getCategoryV1(req.params.id, req.query)

This is so custom queries can be passed through, such as adding include: 'template'

Will also need to update shift-node-api to accept queries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jameskirkby