Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't log in: The name org.freedesktop.secrets was not provided by any .service files #7

Closed
obedm503 opened this issue Dec 14, 2017 · 11 comments

Comments

@obedm503
Copy link

Description

just installed the .deb version from https://github.com/shiftkey/desktop/releases/tag/release-1.0.11 it installed fine but fails to log in to my github account consistently, and shows the error
screenshot_20171214_080239

then I tried the "Sign in using you browser" but that also fails and shows
screenshot_20171214_080620

Version

GitHub Desktop version: 1.0.11

OS version:
image

Steps to Reproduce

  1. install
  2. try to login
  3. fail to login

Expected behavior: log in somehow
Actual behavior: doesn't log in

Reproduces how often: 100%

Logs

couldn't find logs in ~/GitHub Desktop which is where I expected them to be. so these are the logs in the devtools
image
and judging from the network tab, it seems i was successfully authenticated by the server

Additional Information

if there more information needed about the environment feel free to let me know

@shiftkey
Copy link
Owner

@obedm503 thanks for the details!

My initial gut feeling on this is that the login flow where you provide username/password/2fa is failing when we try and add credentials to the OS credential store. We're using node-keytar which then uses libsecret which should work with both GNOME and KDE services for storing secrets, but maybe I'm missing something.

Using the browser to login is probably the same as #10, which is an Electron limitation that was fixed recently. Even if that was working, you'll probably still face the above issue because we need somewhere to store stuff.

@shiftkey
Copy link
Owner

shiftkey commented Dec 26, 2017

Found this extra context for the first error:

keytar uses libsecret, which is a frontend to gnome-keyring. KWallet does not support org.freedesktop.secrets
just installed the package gnome-keyring and everything workes fine

I'm not sure how feasible that is for your use case, but I also don't have enough familiarity with whether there's an alternative to gnome-keyring that's more suitable (KWallet/KSecretService support seems to be an ongoing discussion).

@obedm503
Copy link
Author

so if I install gnome-keyring it should work?

@shiftkey
Copy link
Owner

@obedm503 I believe so

@shiftkey
Copy link
Owner

shiftkey commented Mar 19, 2018

If this can be of some help, in VS Code KWalet is used without problems.

@Bleser92 if you can find out which Node library they're using (and how they're using it) I'm happy to figure out if this can be applied to keytar in some way.

EDIT: I see VSCode is up to 4.0.5 of keytar, which is not far ahead of Desktop which is using 4.0.4 currently.

@mathetes87
Copy link

I'm also using KDE Neon and installing gnome-keyring solved the login problem for me!

@sl1pkn07
Copy link

sl1pkn07 commented Apr 8, 2018

any other alternative? i don't what install gnome-keyring because my system is crafted for gnome-free

is possible use kwallet instead?

@shiftkey
Copy link
Owner

shiftkey commented Apr 8, 2018

is possible use kwallet instead?

Not currently - someone needs to contribute support for KWallet to node-keytar as well as the ability to detect and choose the right backend.

This is the issue discussing that change: atom/node-keytar#17

EDIT: node-keytar actually uses libsecret which is intended to be agnostic of the desktop you use, but KWallet doesn't implement support for it. This is the discussion you want to follow along with.

@shiftkey
Copy link
Owner

shiftkey commented Nov 2, 2018

I'm going to close this out because this is outside the scope of GitHub Desktop. I'd recommend looking for alternatives to KWallet for KDE systems, but I don't seem to be able to find any based on a quick google search.

@shiftkey shiftkey closed this as completed Nov 2, 2018
@obedm503
Copy link
Author

After almost a year, I decided to replace KWallet with Gnome's Seahorse. It now lets me login.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants
@shiftkey @sl1pkn07 @obedm503 @mathetes87 and others