Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all links in the website open on a new tab #131

Closed
shikha-16 opened this issue Aug 31, 2021 · 4 comments
Closed

Make all links in the website open on a new tab #131

shikha-16 opened this issue Aug 31, 2021 · 4 comments
Assignees
@sungod12
Labels
design Issues related to the website design easy good first issue Good for newcomers hacktoberfest website Issues related to the website

Comments

@shikha-16
Copy link
Owner

Make all the links in the website (that go out of the Women in Tech website) open on a new tab
@shikha-16 shikha-16 added design Issues related to the website design easy good first issue Good for newcomers hacktoberfest website Issues related to the website labels Sep 20, 2021
@sungod12
Copy link
Contributor

Hello @shikha-16 ,I can solve this issue, and get back to you as soon as possible. So kindly assign me this issue. Thanks.

@shikha-16
Copy link
Owner Author

Hello @shikha-16 ,I can solve this issue, and get back to you as soon as possible. So kindly assign me this issue. Thanks.

Alright, great! Please join the discord community for further communication, thanks!

sungod12 added a commit to sungod12/Women-in-Technology that referenced this issue Sep 25, 2021
@sungod12
shikha-16#131 changed links to open in new tab
58ebcea 
Fixes #issue131
-Removed warnings occuring due to adding target="_blank".
-Aligned the dark mode icon to center and changed the color on hover to black.
-Solved ValidDOMNesting error due to "a being descendant of p" and "h5 being descendant of p"
-Added keys where map function is used for rendering components.

Breaking change-
-The women in tech logo in inspirations page is aligned to left even though I didn't change the CSS.
nehakalbande added a commit that referenced this issue Oct 2, 2021
@nehakalbande
Merge pull request #148 from sungod12/master
e47f6a4 
#131 changed links to open in new tab
@optimm
Copy link

optimm commented Oct 4, 2021

Hey @shikha-16 is this issue still there , i would like to solve

@sungod12
Copy link
Contributor

sungod12 commented Oct 4, 2021

Hey @shikha-16 is this issue still there , i would like to solve

it's solved. Check above it is already merged. Sorry bro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sungod12 sungod12

Labels
design Issues related to the website design easy good first issue Good for newcomers hacktoberfest website Issues related to the website
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sungod12 @nehakalbande @shikha-16 @optimm