Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scholarships page for the website #56

Closed
umang-sinha opened this issue Oct 10, 2020 · 13 comments · Fixed by #63
Closed

Scholarships page for the website #56

umang-sinha opened this issue Oct 10, 2020 · 13 comments · Fixed by #63
Assignees
Labels
hacktoberfest website Issues related to the website
Projects

Comments

@umang-sinha
Copy link
Collaborator

umang-sinha commented Oct 10, 2020

Contributors interested in working on the scholarships page can take up this issue. You can have a look at the wireframes here.

The scholarships page needs to have the following components:

  • top navigation bar (the top nav bar needs to have dropdowns. Please refer the wireframes and build accordingly)
  • carousel (contributors working on this particular issue can skip the carousel as it has already been assigned to someone else)
  • list of scholarships
  • footer (the footer also needs to have a button that takes the user back to the top of the page when clicked)

Contributors are requested to strictly adhere to the format followed in the wireframes. Please go through Contributing.md and the basic skeleton before contributing.

Also join the Discord server so that communication can be done smoothly.

For an overview of the project, see here

@umang-sinha umang-sinha added hacktoberfest website Issues related to the website labels Oct 10, 2020
@syauqy
Copy link

syauqy commented Oct 10, 2020

Hi @umang-sinha what a great initiative! Can I work on this?

@umang-sinha
Copy link
Collaborator Author

Hey @syauqy thanks for deciding to contribute. I am assigning this to you. You may go ahead and start working on it.

@shikha-16 shikha-16 added this to To Do in Website Oct 10, 2020
@shikha-16
Copy link
Owner

Hi @umang-sinha what a great initiative! Can I work on this?

Hi @syauqy I'm assuming you'll be making the figma design(or any other software) and CSS/react code both yourself?

@syauqy
Copy link

syauqy commented Oct 10, 2020

Hi @shikha-16 since the project only has the wireframe. I think it's better if it push to the high fidelity first. I can help you with Figma for this page as long as we have decided the design guidelines to make sure it doesn't have different style compare to other pages. And also for the react/Gatsby I think I need to wait for the main project to setup first then I can working on this page. What do you think?

@umang-sinha
Copy link
Collaborator Author

umang-sinha commented Oct 10, 2020

Hey @syauqy We have some people working on the website designs. In this issue you are only expected to create a basic skeleton of the page. Further enhancements will be done only once the final designs for the other pages are ready. However you can take a look at the carousel design for the homepage to get a rough idea : https://github.com/shikha-16/Women-in-Technology/tree/master/documents/design/carousels

@syauqy
Copy link

syauqy commented Oct 13, 2020

Hi @shikha-16 and @umang-sinha please check this video of my progress on this page https://www.loom.com/share/f5a2a981d043428387c0fd68e31425a9
I want to make sure it's enough and I can open the PR for this issue.

Here are the screenshots of my work.
Responsive
responsive

Desktop header
desktop1

Desktop footer
desktop2

@shikha-16
Copy link
Owner

Hi @syauqy WOW that looks great. thank you for this amazing work.
So we already have the logo and favicon ready: https://github.com/shikha-16/Women-in-Technology/tree/master/documents/logo so that's something you can add.

We also have the carousel designs ready: https://github.com/shikha-16/Women-in-Technology/tree/master/documents/design/carousels if you want to use those (it's fine if you don't rn)

Everything else looks great to me! Add the logo and favicon, let @umang-sinha also comment, and then you're good to go!

@umang-sinha
Copy link
Collaborator Author

Hey @syauqy This looks perfect to me. This is exactly what we wanted. Great job! As @shikha-16 mentioned, please add the logo and favicons and then you can proceed to make a pull request.

@syauqy
Copy link

syauqy commented Oct 13, 2020

Logo and favicons added
favicon added
Yes, for reusable components like carousel, navbar, and footer, I think we need to work on that separately

@syauqy
Copy link

syauqy commented Oct 13, 2020

please check my PR here #63 . Thanks @umang-sinha @shikha-16

@shikha-16
Copy link
Owner

@syauqy hi, please check out the comment on your PR

@shikha-16 shikha-16 linked a pull request Oct 14, 2020 that will close this issue
@shikha-16 shikha-16 moved this from To Do to Done in Website Oct 14, 2020
@shikha-16
Copy link
Owner

@syauqy maybe you would like to take up another page on the website? we really liked your work, and hope you can contribute more.

@syauqy
Copy link

syauqy commented Oct 14, 2020

Hi @shikha-16 thank you for the offer. Sure, but I think I cannot do it fast. Since I'm only able to work on it on the weekend. Let's see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest website Issues related to the website
Projects
Development

Successfully merging a pull request may close this issue.

3 participants