Move shiny::onStop in vignette #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way this was written, the daemons would be shut down at the end of a _session_, not when the app stops. Signed-off-by: Joe Cheng <joe@posit.co>
shikokuchuo
approved these changes
Mar 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #98 +/- ##
=======================================
Coverage 99.81% 99.81%
=======================================
Files 8 8
Lines 549 549
=======================================
Hits 548 548
Misses 1 1 ☔ View full report in Codecov by Sentry. |
|
FYI a method for app <- shinyApp(ui = ui, server = server)
with(daemons(5), runApp(app))This naturally removes the need to specify when to terminate daemons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way this was written, the daemons would be shut down at the end of a session, not when the app stops.