[BUG] WatchRemoteConfigOnChannel is not working

[hyperjiang]

It can not detect the changes, codes:

package main

import (
	"fmt"
	"log"
	"time"

	remote "github.com/shima-park/agollo/viper-remote"
	"github.com/spf13/viper"
)

func main() {
	remote.SetAppID("vip-service")
	namespaces := []string{"application", "database"}

	vipers := make(map[string]*viper.Viper)
	for _, ns := range namespaces {
		v := viper.New()
		v.SetConfigType("prop")
		err := v.AddRemoteProvider("apollo", "localhost:8080", ns)
		if err != nil {
			log.Fatal(err)
		}
		err = v.ReadRemoteConfig()
		if err != nil {
			log.Fatal(err)
		}

		v.WatchRemoteConfigOnChannel() // not working

		vipers[ns] = v
	}

	for {
		for ns, v := range vipers {
			fmt.Println(ns, v.AllSettings()) // every time gets the same configs
		}
		time.Sleep(5 * time.Second)
	}
}

It works if I switch to use WatchRemoteConfig:

for {
	for ns, v := range vipers {
		err := v.WatchRemoteConfig()
		if err != nil {
			log.Fatal(err)
		}
		fmt.Println(ns, v.AllSettings())
	}
	time.Sleep(5 * time.Second)
}

[shima-park]

I'll check it later when I have time. Thanks for your feedback

[shima-park]

Hi hyperjiang, Sorry for a long time to fix this. I had fix this issue on latest version. You can try this version.

[hyperjiang]

It's working now, thank you.
BTW, your tag for 1.1.10 is not correct, should be v1.1.10
You can safely delete the tag 1.1.10 and tag it as v1.1.10

[shima-park]

awkward😅，I had tag it as v1.1.10