Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

X-ray IDs should not saved in the access history #32

Closed
shimo164 opened this issue Jun 21, 2023 · 3 comments · Fixed by #33
Closed

X-ray IDs should not saved in the access history #32

shimo164 opened this issue Jun 21, 2023 · 3 comments · Fixed by #33
Labels
bug Something isn't working

Comments

@shimo164
Copy link
Owner

shimo164 commented Jun 21, 2023 •
edited
Loading

Describe the bug
In Access from history section of the options page, X-ray IDs are saved as well as Lambda function names.
They should not be saved.

image
@shimo164 shimo164 added the bug Something isn't working label Jun 21, 2023
@shimo164 shimo164 mentioned this issue Jun 21, 2023
Merged
@shimo164 shimo164 linked a pull request Jun 21, 2023 that will close this issue
fix: Xray history will not be saved. Did refactor #33
Merged
@shimo164
Copy link
Owner Author

Not fixed. Reopen.

@shimo164 shimo164 reopened this Jul 26, 2023
@shimo164 shimo164 mentioned this issue Jul 31, 2023
Merged
@shimo164 shimo164 closed this as completed Aug 4, 2023
@shimo164
Copy link
Owner Author

shimo164 commented Aug 4, 2023

Fix confirmed.

@shimo164
Copy link
Owner Author

shimo164 commented Aug 6, 2023

Not fixed on the options page. When opening xray from the options page, the id is saved...

@shimo164 shimo164 reopened this Aug 6, 2023
@shimo164 shimo164 mentioned this issue Aug 6, 2023
Merged
@shimo164 shimo164 closed this as completed Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Xray history will not be saved. Did refactor shimo164/quick-aws-linker
1 participant
@shimo164