Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an helper script to be used with pam_mount #21

Merged
merged 1 commit into from Nov 1, 2020
Merged

Added an helper script to be used with pam_mount #21

merged 1 commit into from Nov 1, 2020

Conversation

aacebedo
Copy link

As we discussed in #20 .
Feel free to integrate it :)
I modified the PKGBUILD and cargo file to install the script but I am not sure of the path.
Can you check it before merging ?

@aacebedo
Copy link
Author

Hi there
Can you give a look to this PR please ? I would like to update my machine initialization scripts and having the helper is needed :)

@shimunn
Copy link
Owner

shimunn commented Oct 17, 2020

Sorry, for the long wait, a couple points for improvement:

  • you seem to have removed the bash completions from the .deb
  • your script requires a PIN to be used, which should be optional
  • I'd be nice to have this in a separate folder like pam_mount

@aacebedo
Copy link
Author

My bad, I deleted the line for the completion.
I added a check for the pincode and moved to the pam_mount folder.

I think there is a problem with the PKGBUILD especially for the path to the script but I do not know how to use it.
Can you take a look ?

@shimunn
Copy link
Owner

shimunn commented Oct 17, 2020

Should be

install -Dm 755 ../pam_mount/fido2luksmounthelper.sh -t "${pkgdir}/usr/bin"

@aacebedo
Copy link
Author

aacebedo commented Oct 31, 2020

Hi
I think I fixed all remarks :)

@shimunn
Copy link
Owner

shimunn commented Oct 31, 2020

forgot to push?

@aacebedo
Copy link
Author

aacebedo commented Nov 1, 2020

Hum I think everything has been pushed in the PR

@shimunn
Copy link
Owner

shimunn commented Nov 1, 2020

I think there is a problem with the PKGBUILD especially for the path to the script but I do not know how to use it.
Can you take a look ?

Should be

install -Dm 755 ../pam_mount/fido2luksmounthelper.sh -t "${pkgdir}/usr/bin"

@aacebedo
Copy link
Author

aacebedo commented Nov 1, 2020

Hum sorry again. Shall be fixed now.

@shimunn shimunn merged commit de21e3e into shimunn:master Nov 1, 2020
@shimunn
Copy link
Owner

shimunn commented Nov 1, 2020

No problem :)

@madonius madonius mentioned this pull request Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants