Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gs lacks parsing of all short-hand permutations #30

Closed
rsa2135 opened this issue Apr 21, 2020 · 4 comments · Fixed by #31
Closed

gs lacks parsing of all short-hand permutations #30

rsa2135 opened this issue Apr 21, 2020 · 4 comments · Fixed by #31
Labels

Comments

@rsa2135
Copy link
Contributor

rsa2135 commented Apr 21, 2020

Issue description

Currently gs only covers a handful (of the more common) status permutation that can occur between the working tree and the index. Specifically, ??, M, M, MM, D, D, DD, R, A, and A .
For all other short-hand permutations, an error is printed to the screen— TODO: UNKNOWN. FIX LATER...
Furthermore, many of the parsed statuses will not appear in all relevant states (to be committed, and not staged), but only in one.

Steps to reproduce the issue

  1. Bring a file in your current branch to a permutation that is not supported.
    For example, a git status --porcelain output of AD added to index, deleted in tree.txt.txt and then

  2. run gs

What's the expected result?

➤ Changes to be committed:

#        new file:  [1] added to index, deleted in tree.txt

➤ Changes not staged for commit:

#         deleted: [2] added to index, deleted in tree.txt

What's the actual result?

➤ Changes to be committed:

AD "added to index, deleted in tree.txt"
TODO: UNKNOWN. FIX LATER...

Additional details / screenshot

Here's an example of an output the shows quite a few of these issues
before

@rsa2135
Copy link
Contributor Author

rsa2135 commented Apr 21, 2020

Would love to contribute, but I'm getting 403 when trying to push. Is the error on my end or is is the repo currently on read-only mode?

@jdelStrother
Copy link
Collaborator

If you fork it and submit a pull request I can merge it in.

@shinriyo
Copy link
Owner

or is is the repo currently on read-only mode?

No it isn't

thank you for your contributed

@rsa2135 rsa2135 mentioned this issue Apr 22, 2020
@rsa2135
Copy link
Contributor Author

rsa2135 commented Apr 22, 2020

Hey, I linked a PR. Here's a screenshot of gss output on the same change list as the output above.
after

Please let me know if you see any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants