Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do you accept PR? #7

Closed
darkeroticism opened this issue Mar 15, 2024 · 3 comments
Closed

Do you accept PR? #7

darkeroticism opened this issue Mar 15, 2024 · 3 comments

Comments

@darkeroticism
Copy link
Contributor

darkeroticism commented Mar 15, 2024

@alex94539
Hello.
I like ShinyColors' standing pictures and would like to save them as images, so I modified main.js a little using the local overrides on the Chrome Developer Tool to make it easier to save.
If possible, I would like to formally submit a PR, but are you willing to accept?

@alex94539
Copy link
Member

Of course you can submit a PR. I'll decide to accept or not depends on the context you submit.
BTW "save as images" is already available on https://mspine.shinycolors.moe, maybe you'd like to try it out(?

@darkeroticism
Copy link
Contributor Author

darkeroticism commented Mar 15, 2024

Oh, I always used https://spine.shinycolors.moe/ .
Are there any differences other than the image save button?

My custom has the following four points,

  • Add image save button
  • Strict file name to save(example: "桑山千雪-Anniversary-【オーバーキャストモノクローム】桑山千雪-一般_演出服.png" )
  • Automatically save images when switching characters, costumes, and types.(It was quite convenient, but I don't make a on/off switch yet.)
  • Disable the animation that was set to wait when changing characters, costumes, and types.(This is more convenient when saving a large number of standing pictures.)

and I was trying to issue a PR for the first two.

@darkeroticism
Copy link
Contributor Author

darkeroticism commented Mar 15, 2024

Also, I like the girl's sad face, 😈 so I fixed it at the initial state of sad (0 frame) and tried to save the image, but in the initial state it stopped in the middle of the blinking animation, Not good.

桑山千雪-P_SR-【夏、イエー】桑山千雪-一般_演出服 (1)

Apparently, due to the structure of spine, there is a function(mixin) to smoothly connect motions in a program and the standing picture I wanted was a moment during the transition from normal state to sad.

I was originally thinking of an approach that would stop the motion and save it automatically, but I realized that it was impossible because the motion I wanted didn't exist.
For this reason, I changed my approach to creating an image save button, but in this case I want slow motion. I would like to implement that in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants