Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model 1 results for warping is unexpected #4

Open
pratiklodha95 opened this issue Oct 3, 2019 · 7 comments
Open

Model 1 results for warping is unexpected #4

pratiklodha95 opened this issue Oct 3, 2019 · 7 comments

Comments

@pratiklodha95
Copy link

I implemented the code as mention in this repo and cp-vton repo.

Everything is working fine, but the model results from the part 1 model is not as expected,
Would like to if there is a specific formats of input one has to give, I have kept all inputs as per your code and data preparation code from cp-vton repo.

image

for simple inputs like
image
image

and
image
image

@shionhonda
Copy link
Owner

Could you give me more information?

  • How did you obtain warp-person.jpg? Is it a warped cloth layered on the person image?
  • What did you input? You need cloth mask, parsed person (by LIP) and pose (by OpenPose) in addition to the pair of person and cloth.

Also, I'm not sure about the extrapolation performance of VITON-GAN. The dataset I used only contains female models.

@jakubLangr
Copy link

Hi @shionhonda @pratiklodha95 I got the same results. Even on the original test files, using the provided GMM epoch 99 file.

000038_1

Thoughts?

@shionhonda
Copy link
Owner

Thanks for reporting @jakubLangr .
That is weird because the result in my local repository looks fine.
000038_1

I might have provided different GMM model file. Let me check.

@shionhonda
Copy link
Owner

shionhonda commented Oct 7, 2019

I did reproduce the successful result by 1) cloning this repository, 2) downloading the dataset and the trained model gmm_epoch_99.pth, and 3) running python run_gmm.py.
Could you check if the trained model is successfully loaded, please? I'm wondering if TPS transform is really working in your case.

@jakubLangr
Copy link

Hi @shionhonda I went ahead and trained your algorithm from scratch. These are the results from my training run over the weekend. The images seem within norms so it seems that the training code for GMM is working on my machine.
image
image

However, I am fairly confident that the pretrained epoch_99 checkpoint is used correctly, as I do not get any file not found errors or similar and the path seems to match the requirement.

I do agree with your suggestion that it is likely that TPS is not working, but I am not sure why.

I am now re-running it on the freshly re-trained model.

Out of curiosity, what setup are you using (Pytorch / Cuda versions?) & OS?

@jakubLangr
Copy link

On re-run with my re-trained model the results are somewhat better. But I am still confused as to why the neck gets removed?

000010_1

@shionhonda
Copy link
Owner

@jakubLangr
Glad to see that your re-running looks fine. But I'm not sure why as well.
I used the setup like:

  • PyTorch 1.2.0 (it should be fine if > 1.0)
  • CUDA 9.0
  • Ubuntu 16.04

Necks are removed in LIP.
http://sysu-hcp.net/lip/parsingchallenge.php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants