Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resumable state #135

Closed
wants to merge 4 commits into from
Closed

Resumable state #135

wants to merge 4 commits into from

Conversation

0t4u
Copy link
Member

@0t4u 0t4u commented Feb 9, 2023

Provides a method for dumping of internal state so that it can be recreated in a new Shoukaku instance.
This would be useful when a bot restarts for updates, as it minimises disruption for users.
This closes #118.

@0t4u 0t4u added the enhancement New feature or request label Feb 9, 2023
@0t4u 0t4u requested a review from Deivu as a code owner February 9, 2023 17:02
@0t4u
Copy link
Member Author

0t4u commented Feb 9, 2023

p.s. code has not been tested, further investigation is required to see if this is reliable, and see how much resources it consumes

@flav-code
Copy link
Contributor

p.s. code has not been tested, further investigation is required to see if this is reliable, and see how much resources it consumes

I can test on my side and correct bugs

@JoniXTech
Copy link

but how can you avoid errors like these:

{
code: 4006,
reason: 'Session is no longer valid.',
byRemote: true,
guildId: '972875190071595058',
op: 'event',
type: 'WebSocketClosedEvent'
}

or is it possible to create a new session Id (discord) for the player update?

@flav-code
Copy link
Contributor

but how can you avoid errors like these:

{ code: 4006, reason: 'Session is no longer valid.', byRemote: true, guildId: '972875190071595058', op: 'event', type: 'WebSocketClosedEvent' }

or is it possible to create a new session Id (discord) for the player update?

idk

@0t4u
Copy link
Member Author

0t4u commented Jul 15, 2023

PR needs to be updated for #158 in the future.

@0t4u 0t4u closed this Jul 15, 2023
@0t4u 0t4u deleted the feature-resume-state branch July 15, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When restarting the bot and leaving Lavalink running it wont reconnect to the old player
4 participants