Skip to content
This repository has been archived by the owner on Mar 18, 2018. It is now read-only.

Change workspace to be more explicit #58

Closed
gregberge opened this issue Apr 29, 2015 · 3 comments
Closed

Change workspace to be more explicit #58

gregberge opened this issue Apr 29, 2015 · 3 comments

Comments

@gregberge
Copy link
Member

shipitjs/shipit#61

@tom2strobl
Copy link

+1
I had the same "workspace"-experience as the guy in the other thread, luckily I just boilerplated a new project - yet everything was gone, was pretty mad

@gregberge
Copy link
Member Author

@tom2strobl can you propose another name?

@tom2strobl
Copy link

I don't think it's a naming issue, but a description issue, so for example instead of

Define the local working path of the project deployed.

which doesn't really tell me anything about what happens at the path – I'd suggest something around

Define a path to an empty directory where shipit builds it's syncing source, beware to not set this path to the root of your repository as shipit-deploy cleans the directory at the given path as a first step.

I think destructive commands as rm -rf on dynamic paths always demand documentation. I also don't think you can provide too much information in the docs.

By the way, once I got the hang of it I thoroughly enjoyed the library. What I really like about the approach is that on the server part you don't really have to install anything, the only dependency really is that you ssh via key – I wonder if the magic would also be possible with providing a password instead of a keyfile? (as in client projects we're not always allowed to authorize our keys)

Either way, keep it up!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

2 participants