Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Step.id to typings, fix tour.getById() typing #1044

Merged
merged 1 commit into from Jul 13, 2020
Merged

add Step.id to typings, fix tour.getById() typing #1044

merged 1 commit into from Jul 13, 2020

Conversation

cyremur
Copy link
Contributor

@cyremur cyremur commented Jul 13, 2020

Exposes the id property of Step in TypeScript.
Fix the typing of Tour.getById() which can return null if given an id that's not in the tour.

@cyremur cyremur mentioned this pull request Jul 13, 2020
Closed
@RobbieTheWagner RobbieTheWagner merged commit 440d3e0 into shepherd-pro:master Jul 13, 2020
@RobbieTheWagner
Copy link
Member

Thanks so much for the PR @cyremur!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobbieTheWagner RobbieTheWagner RobbieTheWagner approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cyremur @RobbieTheWagner