Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write jest-environment-jsdom into package.json file #1919

Merged
merged 4 commits into from May 16, 2022
Merged

Write jest-environment-jsdom into package.json file #1919

merged 4 commits into from May 16, 2022

Conversation

monshan
Copy link
Contributor

@monshan monshan commented May 16, 2022 •
edited

Background:
Bugfix: #1907 not passing Unit Tests

Changes:

  • Manual update Jest to version ^28.0.1
  • Add docblock at the top of all test suites to define the testEnvironment variable according to the Jest configuration docs

chuckcarpenter
chuckcarpenter approved these changes May 16, 2022
View reviewed changes
Copy link
Contributor

@chuckcarpenter chuckcarpenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@monshan monshan merged commit e0a1c94 into master May 16, 2022
@monshan monshan deleted the add-jest-environment-jsdom-dependency branch May 16, 2022 18:43
@monshan monshan restored the add-jest-environment-jsdom-dependency branch May 16, 2022 18:48
@RobbieTheWagner RobbieTheWagner deleted the add-jest-environment-jsdom-dependency branch May 16, 2022 18:51
@monshan monshan mentioned this pull request May 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chuckcarpenter chuckcarpenter chuckcarpenter approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@monshan @chuckcarpenter @RobbieTheWagner