Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in ThemeGeneratorCommand : title_case #40

Closed
ghost opened this issue May 1, 2020 · 1 comment
Closed

Bug in ThemeGeneratorCommand : title_case #40

ghost opened this issue May 1, 2020 · 1 comment

Comments

@ghost
Copy link

ghost commented May 1, 2020

Hi.

There is a little bug, when i launched this command (at description) :

  Call to undefined function Shipu\Themevel\Console\title_case()
  at vendor/shipu/themevel/src/Console/ThemeGeneratorCommand.php:146

I have checked the code source, indeed, since laravel 5.7, the method title_case is remplaced by Str::title
See manual : https://laravel.com/docs/7.x/helpers#method-title-case

I will try to do a pull request to fix it. ( It is my first time). Maybe it is better to create another branches : 1 for < 5.7 and 1 another for >= 5.7.

( I love your package :-) )

Best regards.

@ghost ghost mentioned this issue May 1, 2020
@Shipu
Copy link
Owner

Shipu commented May 9, 2020

Merged

@Shipu Shipu closed this as completed May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant