Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom attributes from the Build CR could be used as parameters while defining a BuildStrategy #537

Open
sbose78 opened this issue Jan 18, 2021 · 1 comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@sbose78
Copy link
Member

sbose78 commented Jan 18, 2021

Parameterization

Attributes from the Build CR could be used as parameters while defining a BuildStrategy.

Examples:

$(build.output.image) implies that the Build CR's spec.output.image value be used.

$(build.parameters.skip_ssl_verify) implies that the value corresponding to key skip_ssl_verify in Build CR's spec.parameters be used.

Wider context https://github.com/shipwright-io/build/blob/master/docs/proposals/buildstrategy.md#parameterization

@sbose78 sbose78 added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 18, 2021
@gabemontero
Copy link
Member

@sbose78 - when we presumably expand on this in an EP, the EP should also allow a means for cluster administrators to control when parameters a given user could set on their Build instances

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants