Should we remove the Flavor from source to avoid the confusion?

[zhangtbj]

Hi @sbose78 ,

We added a GitLab test in this PR: Add env variables for the e2e tests (#87)

And in the test, we just need to input the GitLab URL like Github in the spec.source.url:
https://github.com/redhat-developer/build/blob/master/test/data/build_buildah_cr_private_gitlab.yaml#L8

So I thought all repo should follow a similar standard that we don't need to do any additional render work.

But now, we still have a Flavor parameter in source spec:
https://github.com/redhat-developer/build/blob/master/pkg/apis/build/v1alpha1/gitsource.go#L34

I think if all repo can use the same style, we should remove it to avoid the confusion now.

[sbose78]

The reason for adding the flavour was to support git provider based webhook-related behaviour in the future.

At the moment, I don't have design in mind to implement it. I'm okay to remove it now and bring it back later on when we have a design in place which consumes this.

[zhangtbj]

Agree.

em... interesting.

For the webhook or trigger functions, I think we can have more discussion about how to do it better in the future.

[qu1queee]

@zhangtbj I think the Flavor field is not used in our logic, it seems the answer is lets keep the field for now while it might be useful in the future. If this is the case, can we close this issue?

[zhangtbj]

Sure thing.